add size to snapshot list #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing. Thank you! I pushed a couple of commits just to update the branch and fix the tests. |
|
thanks for fixing the tests! is running tests on PRs disabled? I would also totally have done it myself |
|
Yes. It's currently set to require manual approval for first-time collaborators. And no worries. It was a one-line fix and to be honest I just didn't want to wait so that's on me 😛 Thanks for the contribution though, it's working great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7
Size calculation is fast on my machine so it doesn't hurt to do it even when we don't need it.
I'm happy to refactor it to just pull the size when needed, so in the cli/list method.